-Split Asset / created instance more cleanly.
-Asset provides an RenderLoop instance that can be used for rendering
-Remove data store (implicitly the loop instance now)
Update to the RenderPipes to support the new paradigm on how to go about writing a renderpipe.
Renderloops now should only contain configuration information + a call out to the rendering logic (preferably living in a static function). A loop now executes within a 'rendering context' that passes along a sidecar configuration file called a 'DataStore'. Any transient information that is needed between frames should be stored in this datastore (things like the materials / rendertextures). When the renderloop is destroyed this sidecar data is automatically cleaned up. It can also be cleaned manually.
Currently only the BasicRenderLoop has been ported to this new model due to the other loops not having a separation of concerns between transient data and configuration. They need the loop owners to detangle this before porting to the new model can take place. These existing loops still work, but they suffer from the same lifecycle issues they have had up unti...
(when the selection didn't change the global selection wouldn't be changed - e.g. "select node in graph, select something from the scene, click selected node" wouldn't select the graph in the project window)
It is called in every frame and calls `parent.allElements` twice to find the GraphElement for its anchors. The implementation of `allElements` is very slow right now (as is noted in `VisualContainer.cs` comments), but either way we should avoid a traversal of all `VisualElement`'s for every edge every frame.
Both issues were caused by the nodes positioning incorrectly being flagged as
Relative. Putting it to Absolute fixed all of this. It also messed with the
nodes positioning, which is why the ShaderGraphs had to be changed as well.
Signed-off-by: joce <joce@unity3d.com>
Evgenii Golubev
GitHub
Tim Cooper
Julien Ignace
runes
Peter Bay Bastian
joce