浏览代码

[release] Fix rl trainer warning (#5144)

* Fix rl trainer warning

* Fix typo
/release_15_branch
GitHub 3 年前
当前提交
8387e252
共有 2 个文件被更改,包括 33 次插入1 次删除
  1. 32
      ml-agents/mlagents/trainers/tests/test_rl_trainer.py
  2. 2
      ml-agents/mlagents/trainers/trainer/rl_trainer.py

32
ml-agents/mlagents/trainers/tests/test_rl_trainer.py


import os
import unittest
from unittest import mock
import pytest
import mlagents.trainers.tests.mock_brain as mb

for step in checkpoint_range
]
mock_add_checkpoint.assert_has_calls(add_checkpoint_calls)
class RLTrainerWarningTest(unittest.TestCase):
def test_warning_group_reward(self):
with self.assertLogs("mlagents.trainers", level="WARN") as cm:
rl_trainer = create_rl_trainer()
# This one should warn
trajectory = mb.make_fake_trajectory(
length=10,
observation_specs=create_observation_specs_with_shapes([(1,)]),
max_step_complete=True,
action_spec=ActionSpec.create_discrete((2,)),
group_reward=1.0,
)
buff = trajectory.to_agentbuffer()
rl_trainer._warn_if_group_reward(buff)
assert len(cm.output) > 0
len_of_first_warning = len(cm.output)
rl_trainer = create_rl_trainer()
# This one shouldn't
trajectory = mb.make_fake_trajectory(
length=10,
observation_specs=create_observation_specs_with_shapes([(1,)]),
max_step_complete=True,
action_spec=ActionSpec.create_discrete((2,)),
)
buff = trajectory.to_agentbuffer()
rl_trainer._warn_if_group_reward(buff)
# Make sure warnings don't get bigger
assert len(cm.output) == len_of_first_warning

2
ml-agents/mlagents/trainers/trainer/rl_trainer.py


Warn if the trainer receives a Group Reward but isn't a multiagent trainer (e.g. POCA).
"""
if not self._has_warned_group_rewards:
if not np.any(buffer[BufferKey.GROUP_REWARD]):
if np.any(buffer[BufferKey.GROUP_REWARD]):
logger.warning(
"An agent recieved a Group Reward, but you are not using a multi-agent trainer. "
"Please use the POCA trainer for best results."

正在加载...
取消
保存