Merge branch 'dragdrop_fix' into 'master'

Code Cleanup Setting （EditorConfig + DotSettings) See merge request upm-packages/ui-widgets/com.unity.uiwidgets!25
6 年前 · 6abdca18
--- a/README.md
+++ b/README.md
 Specify Upstream URL as "git@gitlab.cds.internal.unity3d.com:upm-packages/ui-widgets/idea-settings.git"
 and click "Overwrite Local" or "Merge".

-REF: https://www.jetbrains.com/help/idea/sharing-your-ide-settings.html#settings-repository
+REF: https://www.jetbrains.com/help/idea/sharing-your-ide-settings.html#settings-repository
+
+
+## Code Style
+
+1. **Import the Customized Code Cleanup Settings**: Open Preferences -> Manage Layers, 
+Choose 'Solution "\<YourProjectName\>" personal' and Click "Add Layer" ("+") -> "Open Settings File...".
+and Open the file "UIWidgetCleanupPlugin.DotSettings" under \<YourProjectPath\>/Packages/com.unity.uiwidgets/"
+
+2. **Cleanup Code style using the Customized Code Cleanup Settings**: Open Code -> Code Cleanup,
+Pick a Cleanup scope as you want and Choose "UIWidgets" as the "Code cleanup profile", then click "OK"
+
+3. **Refine Code Style Rules**: Edit the ".editorconfig" file under \<YourProjectPath\>/Packages/com.unity.uiwidgets/". Visit
+ https://www.jetbrains.com/help/rider/EditorConfig_Index.html for the detailed.
+ 
+REF: https://www.jetbrains.com/help/rider/Sharing_Configuration_Options.html
--- a/.editorconfig
+++ b/.editorconfig
+##########################################
+####                                  ####
+#### EditorConfig for JetBrains Rider ####
+####                                  ####
+####              by Project UIWidget ####
+####                                  ####
+##########################################
+
+################# How to #################
+# 
+# (1) Code Cleanup
+#
+# Prepare: Preferences -> Manage Layers ->
+# add a layer from UIWidgetCleanupPlugin.
+# DotSettings to your personal layer
+#
+# Whenever want to clean-up, use 
+# Menu -> Code -> Code Cleanup -> UIWidget
+# -> OK
+#
+#
+# (2) Code Inspect
+# Preferences -> Editor -> Inspection
+# Settings -> select "Read settings from 
+# editorconfig..."
+#
+############################################
+
+
+#### !!!! EditorConfig Starts Here !!!! #####
+root = true
+
+# For CSharp Only
+[*.cs]
+
+################
+# Code Cleanup #
+################
+
+# indents (4 spaces)
+indent_style=space
+indent_size=4
+
+
+# no requirement for converting type declaration to var
+csharp_for_built_in_types=can_use_either
+csharp_for_other_types=can_use_either
+csharp_for_simple_types=can_use_either
+
+
+# use this.{} for all instance members
+csharp_instance_members_qualify_members=all
+
+
+# all braces start at the end of a line
+csharp_brace_style=end_of_line
+
+
+# don't use 'private' whenever possible
+csharp_default_private_modifier=implicit
+
+
+# not requirement for converting named arguments into positioned arguments whenever possible
+csharp_arguments_named=named
+
+
+###################
+# CODE INSPECTION #
+###################
+
+# use this.{} for all instance members
+resharper_arrange_this_qualifier_highlighting=error
--- a/UIWidgetCleanupPlugin.DotSettings
+++ b/UIWidgetCleanupPlugin.DotSettings
+<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
+	<s:String x:Key="/Default/CodeStyle/CodeCleanup/Profiles/=UIWidgets/@EntryIndexedValue">&lt;?xml version="1.0" encoding="utf-16"?&gt;&lt;Profile name="UIWidgets"&gt;&lt;JsReformatCode&gt;True&lt;/JsReformatCode&gt;&lt;CSCodeStyleAttributes ArrangeTypeAccessModifier="True" ArrangeTypeMemberAccessModifier="True" SortModifiers="False" RemoveRedundantParentheses="False" AddMissingParentheses="True" ArrangeBraces="False" ArrangeAttributes="False" ArrangeArgumentsStyle="False" ArrangeCodeBodyStyle="False" ArrangeVarStyle="False" /&gt;&lt;CSOptimizeUsings&gt;&lt;OptimizeUsings&gt;True&lt;/OptimizeUsings&gt;&lt;EmbraceInRegion&gt;False&lt;/EmbraceInRegion&gt;&lt;RegionName&gt;&lt;/RegionName&gt;&lt;/CSOptimizeUsings&gt;&lt;CSReformatCode&gt;True&lt;/CSReformatCode&gt;&lt;CSFixBuiltinTypeReferences&gt;True&lt;/CSFixBuiltinTypeReferences&gt;&lt;CSArrangeQualifiers&gt;True&lt;/CSArrangeQualifiers&gt;&lt;CSShortenReferences&gt;True&lt;/CSShortenReferences&gt;&lt;IDEA_SETTINGS&gt;&amp;lt;profile version="1.0"&amp;gt;
+  &amp;lt;option name="myName" value="UIWidgets" /&amp;gt;
+  &amp;lt;inspection_tool class="ES6ShorthandObjectProperty" enabled="false" level="INFORMATION" enabled_by_default="false" /&amp;gt;
+  &amp;lt;inspection_tool class="JSArrowFunctionBracesCanBeRemoved" enabled="false" level="INFORMATION" enabled_by_default="false" /&amp;gt;
+  &amp;lt;inspection_tool class="JSPrimitiveTypeWrapperUsage" enabled="false" level="WARNING" enabled_by_default="false" /&amp;gt;
+  &amp;lt;inspection_tool class="JSRemoveUnnecessaryParentheses" enabled="false" level="INFORMATION" enabled_by_default="false" /&amp;gt;
+  &amp;lt;inspection_tool class="JSUnnecessarySemicolon" enabled="false" level="WARNING" enabled_by_default="false" /&amp;gt;
+  &amp;lt;inspection_tool class="TypescriptExplicitMemberType" enabled="false" level="INFORMATION" enabled_by_default="false" /&amp;gt;
+  &amp;lt;inspection_tool class="UnnecessaryContinueJS" enabled="false" level="WARNING" enabled_by_default="false" /&amp;gt;
+  &amp;lt;inspection_tool class="UnnecessaryLabelJS" enabled="false" level="WARNING" enabled_by_default="false" /&amp;gt;
+  &amp;lt;inspection_tool class="UnnecessaryLabelOnBreakStatementJS" enabled="false" level="WARNING" enabled_by_default="false" /&amp;gt;
+  &amp;lt;inspection_tool class="UnnecessaryLabelOnContinueStatementJS" enabled="false" level="WARNING" enabled_by_default="false" /&amp;gt;
+  &amp;lt;inspection_tool class="UnnecessaryReturnJS" enabled="false" level="WARNING" enabled_by_default="false" /&amp;gt;
+  &amp;lt;inspection_tool class="UnterminatedStatementJS" enabled="false" level="WARNING" enabled_by_default="false" /&amp;gt;
+&amp;lt;/profile&amp;gt;&lt;/IDEA_SETTINGS&gt;&lt;XAMLCollapseEmptyTags&gt;False&lt;/XAMLCollapseEmptyTags&gt;&lt;RemoveCodeRedundanciesVB&gt;True&lt;/RemoveCodeRedundanciesVB&gt;&lt;VBOptimizeImports&gt;True&lt;/VBOptimizeImports&gt;&lt;VBShortenReferences&gt;True&lt;/VBShortenReferences&gt;&lt;VBFormatDocComments&gt;True&lt;/VBFormatDocComments&gt;&lt;CssAlphabetizeProperties&gt;True&lt;/CssAlphabetizeProperties&gt;&lt;/Profile&gt;</s:String></wpf:ResourceDictionary>