parallax occlusion mapping node - added support for height scalar parameter

MaterialGraphProject/Assets/NewNodes/WIP/POMNode.cs

         IMayRequireNormal,
         IMayRequireViewDirectionTangentSpace
     {
+        protected const string kInputHeightScaleShaderName = "HeightScale";
-        
-        public const int TextureSlotId = 0;             // 'tex'
-        public const int OutputSlotId = 1;
+
+        public const int HeightScaleSlotId = 0;         // 'height_scale'
+        public const int TextureSlotId = 1;             // 'tex'
+        public const int OutputSlotId = 2;
 
         public override bool hasPreview
         {
 
         public sealed override void UpdateNodeAfterDeserialization()
         {
+            AddSlot(GetInputHeightScaleSlot());
+
-            get { return new[] { TextureSlotId, OutputSlotId }; }
+            get { return new[] { HeightScaleSlotId, TextureSlotId, OutputSlotId }; }
-           
+        protected virtual string GetInputHeightScaleName()
+        {
+            return kInputHeightScaleShaderName;
+        }
+        protected virtual MaterialSlot GetInputHeightScaleSlot()
+        {
+            return new MaterialSlot(
+                HeightScaleSlotId, GetInputHeightScaleName(), kInputHeightScaleShaderName, SlotType.Input, SlotValueType.Vector1, Vector4.zero);
+        }
         protected virtual MaterialSlot GetTextureSlot()
         {
             return new MaterialSlot(TextureSlotId, GetTextureSlotName(), kTextureSlotShaderName, SlotType.Input, SlotValueType.sampler2D, Vector4.zero);
             return kOutputSlotShaderName;
         }
 
+        private string inputHeightScaleDimension
+        {
+            get { return ConvertConcreteSlotValueTypeToString(FindInputSlot<MaterialSlot>(HeightScaleSlotId).concreteValueType); }
+        }
+
-            string tex, string UVs, string viewTangentSpace, string worldSpaceNormal, string worldSpaceViewDirection)
+            string heightScale, string tex, string UVs, string viewTangentSpace, string worldSpaceNormal, string worldSpaceViewDirection)
+                precision + inputHeightScaleDimension + " " + heightScale + ", " + 
                 "sampler2D " + tex + ", " +
                 precision + "2 " + UVs + ", " +
                 precision + "3 " + viewTangentSpace + ", " +
         {
             NodeUtils.SlotConfigurationExceptionIfBadConfiguration(
                 this, 
-                new[] { TextureSlotId }, 
+                new[] { HeightScaleSlotId, TextureSlotId }, 
+            string heightScaleValue = GetSlotValue(HeightScaleSlotId, generationMode);
-                GetFunctionCallBody(textureValue) + ";", true);
+                GetFunctionCallBody(heightScaleValue, textureValue) + ";", true);
         }
 
         public void GenerateNodeFunction(ShaderGenerator visitor, GenerationMode generationMode)
-                    GetFunctionPrototype("tex", "UVs", "viewTangentSpace", "worldSpaceNormal", "worldSpaceViewDirection" ), 
+                    GetFunctionPrototype("heightScale", "tex", "UVs", "viewTangentSpace", "worldSpaceNormal", "worldSpaceViewDirection" ), 
                     false);
             
             outputString.AddShaderChunk("{", false);
             // to computing a bump mapping result:
             outputString.AddShaderChunk(precision + "2 " + "result_texcoord = texcoord;", false);
 
-            outputString.AddShaderChunk("float height_scale_value = 1.0f;", false);
-            outputString.AddShaderChunk("float height_scale_adjust = 0.02f;", false);
+            outputString.AddShaderChunk("float height_scale_value = heightScale;", false);
+            outputString.AddShaderChunk("float height_scale_adjust = height_scale_value;", false);
-            outputString.AddShaderChunk("float per_pixel_height_scale_value = height_scale_value * height_scale_adjust;", false);
-
-            outputString.AddShaderChunk("if (per_pixel_height_scale_value > 0)", false);
-            outputString.AddShaderChunk("{", false);
-            outputString.Indent();
-
+            outputString.AddShaderChunk("float per_pixel_height_scale_value = height_scale_value * heightScale;", false);
+            
             // Parallax occlusion mapping offset computation 
             //--------------
 
 
             // Need to scale the amount of displacement to account for different height ranges
             // in height maps. This is controlled by an artist-editable parameter:
-            outputString.AddShaderChunk("parallax_offset_in_tangent_space *= per_pixel_height_scale_value;", false);
+            outputString.AddShaderChunk("parallax_offset_in_tangent_space *= saturate(heightScale);", false); 
 
             outputString.AddShaderChunk("float2 texcoord_offset_per_step = step_size * parallax_offset_in_tangent_space;", false);
 
             // The computed texture offset for the displaced point on the pseudo-extruded surface:
             outputString.AddShaderChunk("float2 parallaxed_texcoord = texcoord - parallax_offset;", false);
 
-            outputString.AddShaderChunk("result_texcoord = parallaxed_texcoord;", false);
-            outputString.Deindent();
-            outputString.AddShaderChunk("}", false);
-            
-            outputString.Deindent();
-					
-            outputString.AddShaderChunk("return result_texcoord;", false);
-            
+            outputString.AddShaderChunk("return parallaxed_texcoord;", false);
+
             outputString.Deindent();
             outputString.AddShaderChunk("}", false);
 
-        protected virtual string GetFunctionCallBody(string texValue)
+        protected virtual string GetFunctionCallBody(string heightScale, string texValue)
+                heightScale + ", " + 
                 texValue + ", " +
                 channel.GetUVName() + ", " +
                 ShaderGeneratorNames.TangentSpaceViewDirection + ", " +