Correct menu items that should be internal/not internal

ScriptableRenderPipeline/Core/CoreUtils.cs

 
     public static class CoreUtils
     {
-        public const int editMenuPriority = 320;
-        public const int assetCreateMenuPriority = 230;
+        public const int editMenuPriority1 = 320;
+        public const int editMenuPriority2 = 331;
+        public const int assetCreateMenuPriority1 = 230;
+        public const int assetCreateMenuPriority2 = 241;
 
         // Render Target Management.
         public static void SetRenderTarget(CommandBuffer cmd, RenderTargetIdentifier buffer, ClearFlag clearFlag, Color clearColor, int miplevel = 0, CubemapFace cubemapFace = CubemapFace.Unknown)

ScriptableRenderPipeline/Core/Debugging/Editor/DebugMenuEditor.cs

         [SerializeField]
         private DebugMenuState m_DebugMenuState;
 
-        [MenuItem("Edit/Render Pipeline/High Definition/Tools/Debug Window", priority = CoreUtils.editMenuPriority)]
+        [MenuItem("Edit/Render Pipeline/Tools/High Definition/Debug Window", priority = CoreUtils.editMenuPriority2)]
         static void DisplayDebugMenu()
         {
             var window = EditorWindow.GetWindow<DebugMenuEditor>("Debug Window");

ScriptableRenderPipeline/Core/ShaderGenerator/Editor/ShaderGeneratorMenu.cs

+using UnityEngine.Experimental.Rendering;
+
-        [UnityEditor.MenuItem("Internal/RenderPipeline/Generate Shader Includes")]
+        [UnityEditor.MenuItem("Edit/Render Pipeline/Tools/Generate Shader Includes", priority = CoreUtils.editMenuPriority1)]
         static void GenerateShaderIncludes()
         {
             CSharpToHLSL.GenerateAll();

ScriptableRenderPipeline/HDRenderPipeline/Editor/HDAssetFactory.cs

             get { return HDEditorUtils.GetHDRenderPipelinePath() + "RenderPipelineResources/HDRenderPipelineResources.asset"; }
         }
 
-        [MenuItem("Assets/Create/Render Pipeline/High Definition/Render Pipeline", priority = CoreUtils.assetCreateMenuPriority)]
+        [MenuItem("Assets/Create/Render Pipeline/High Definition/Render Pipeline", priority = CoreUtils.assetCreateMenuPriority1)]
         static void CreateHDRenderPipeline()
         {
             var instance = ScriptableObject.CreateInstance<HDRenderPipelineAsset>();
 
         // TODO skybox/cubemap
 
-        [MenuItem("Assets/Create/Render Pipeline/High Definition/Render Pipeline Resources")]
+        [MenuItem("Assets/Create/Render Pipeline/High Definition/Render Pipeline Resources", priority = CoreUtils.assetCreateMenuPriority2)]
         static void CreateRenderPipelineResources()
         {
             string HDRenderPipelinePath = HDEditorUtils.GetHDRenderPipelinePath();

ScriptableRenderPipeline/HDRenderPipeline/Editor/HDRenderPipelineMenuItems.cs

 
     public class HDRenderPipelineMenuItems
     {
-        [MenuItem("Edit/Render Pipeline/High Definition/Upgrade/Add \"Additional Light-shadow Data\" (if not present)", priority = CoreUtils.editMenuPriority)]
+        [MenuItem("Internal/HDRenderPipeline/Add \"Additional Light-shadow Data\" (if not present)")]
         static void AddAdditionalLightData()
         {
             var lights = UnityObject.FindObjectsOfType(typeof(Light)) as Light[];
             }
         }
 
-        [MenuItem("Edit/Render Pipeline/High Definition/Upgrade/Add \"Additional Camera Data\" (if not present)", priority = CoreUtils.editMenuPriority)]
+        [MenuItem("Internal/HDRenderPipeline/Add \"Additional Camera Data\" (if not present)")]
         static void AddAdditionalCameraData()
         {
             var cameras = UnityObject.FindObjectsOfType(typeof(Camera)) as Camera[];
         // In case the shader code have change and the inspector have been update with new kind of keywords we need to regenerate the set of keywords use by the material.
         // This script will remove all keyword of a material and trigger the inspector that will re-setup all the used keywords.
         // It require that the inspector of the material have a static function call that update all keyword based on material properties.
-        [MenuItem("Internal/HDRenderPipeline/Test/Reset all materials keywords")]
+        [MenuItem("Edit/Render Pipeline/Upgrade/High Definition/Reset All Materials Keywords (Loaded Materials)", priority = CoreUtils.editMenuPriority2)]
         static void ResetAllMaterialKeywords()
         {
             try
             }
         }
 
-        [MenuItem("Internal/HDRenderPipeline/Test/Reset all materials keywords in project")]
+        [MenuItem("Edit/Render Pipeline/Upgrade/High Definition/Reset All Materials Keywords (Materials in Project)", priority = CoreUtils.editMenuPriority2)]
         static void ResetAllMaterialKeywordsInProject()
         {
             try
             }
         }
 
-        [MenuItem("Edit/Render Pipeline/High Definition/Upgrade/Update SSS Profile Indices", priority = CoreUtils.editMenuPriority)]
+        [MenuItem("Internal/HDRenderPipeline/Update/Update SSS profile indices")]
         static void UpdateSSSProfileIndices()
         {
             try
             }
         }
 
-        [MenuItem("Edit/Render Pipeline/High Definition/Tools/Export Sky to Image", priority = CoreUtils.editMenuPriority)]
+        [MenuItem("Edit/Render Pipeline/Tools/High Definition/Export Sky to Image", priority = CoreUtils.editMenuPriority2)]
         static void ExportSkyToImage()
         {
             var renderpipeline = RenderPipelineManager.currentPipeline as HDRenderPipeline;
         class DoCreateNewAssetProceduralSkySettings : DoCreateNewAsset<ProceduralSkySettings> {}
         class DoCreateNewAssetSubsurfaceScatteringSettings : DoCreateNewAsset<SubsurfaceScatteringSettings> {}
 
-        [MenuItem("Assets/Create/Render Pipeline/High Definition/Common Settings")]
+        [MenuItem("Assets/Create/Render Pipeline/High Definition/Common Settings", priority = CoreUtils.assetCreateMenuPriority2)]
         static void MenuCreateCommonSettings()
         {
             var icon = EditorGUIUtility.FindTexture("ScriptableObject Icon");
-        [MenuItem("Assets/Create/Render Pipeline/High Definition/Subsurface Scattering Settings")]
+        [MenuItem("Assets/Create/Render Pipeline/High Definition/Subsurface Scattering Settings", priority = CoreUtils.assetCreateMenuPriority2)]
         static void MenuCreateSubsurfaceScatteringProfile()
         {
             var icon = EditorGUIUtility.FindTexture("ScriptableObject Icon");
-        [MenuItem("Assets/Create/Render Pipeline/High Definition/HDRISky Settings")]
+        [MenuItem("Assets/Create/Render Pipeline/High Definition/HDRISky Settings", priority = CoreUtils.assetCreateMenuPriority2)]
         static void MenuCreateHDRISkySettings()
         {
             var icon = EditorGUIUtility.FindTexture("ScriptableObject Icon");
-        [MenuItem("Assets/Create/Render Pipeline/High Definition/BlacksmithSky Settings")]
+        [MenuItem("Assets/Create/Render Pipeline/High Definition/BlacksmithSky Settings", priority = CoreUtils.assetCreateMenuPriority2)]
         static void MenuCreateBlacksmithSkySettings()
         {
             var icon = EditorGUIUtility.FindTexture("ScriptableObject Icon");
-        [MenuItem("Assets/Create/Render Pipeline/High Definition/ProceduralSky Settings")]
+        [MenuItem("Assets/Create/Render Pipeline/High Definition/ProceduralSky Settings", priority = CoreUtils.assetCreateMenuPriority2)]
         static void MenuCreateProceduralSkySettings()
         {
             var icon = EditorGUIUtility.FindTexture("ScriptableObject Icon");

ScriptableRenderPipeline/HDRenderPipeline/Editor/UpgradeStandardShaderMaterials.cs

             return upgraders;
         }
 
-        [MenuItem("Edit/Render Pipeline/High Definition/Upgrade/Upgrade Standard Materials to Lit Materials (Project)", priority = CoreUtils.editMenuPriority)]
+        [MenuItem("Edit/Render Pipeline/Upgrade/High Definition/Upgrade Standard Materials to Lit Materials (Project)", priority = CoreUtils.editMenuPriority2)]
-        [MenuItem("Edit/Render Pipeline/High Definition/Upgrade/Upgrade Standard Materials to Lit Materials (Selection)", priority = CoreUtils.editMenuPriority)]
+        [MenuItem("Edit/Render Pipeline/Upgrade/High Definition/Upgrade Standard Materials to Lit Materials (Selection)", priority = CoreUtils.editMenuPriority2)]
-        [MenuItem("Edit/Render Pipeline/High Definition/Upgrade/Modify Light Intensity for Upgrade (Scene Only)", priority = CoreUtils.editMenuPriority)]
+        [MenuItem("Edit/Render Pipeline/Upgrade/High Definition/Modify Light Intensity for Upgrade (Scene Only)", priority = CoreUtils.editMenuPriority2)]
         static void UpgradeLights()
         {
             Light[] lights = Light.GetLights(LightType.Directional, 0);

ScriptableRenderPipeline/LightweightPipeline/Editor/LegacyShadersToLightweightPipelineUpgrader.cs

 {
     public class LegacyShadersToLightweightPipelineUpgrader
     {
-        //[MenuItem("Edit/Render Pipeline/Lightweight/Upgrade/Upgrade Legacy Materials to Lightweight Pipeline (Project)", priority = CoreUtils.editMenuPriority)]
+        //[MenuItem("Edit/Render Pipeline/Upgrade/Lightweight/Upgrade Legacy Materials to Lightweight Pipeline (Project)", priority = CoreUtils.editMenuPriority)]
         //public static void UpgradeMaterialsToLDProject()
         //{
         //    List<MaterialUpgrader> materialUpgraders = new List<MaterialUpgrader>();
 
-        //[MenuItem("Edit/Render Pipeline/Lightweight/Upgrade/Upgrade Legacy Materials to Lightweight Pipeline (Selection)", priority = CoreUtils.editMenuPriority)]
+        //[MenuItem("Edit/Render Pipeline/Upgrade/Lightweight/Upgrade Legacy Materials to Lightweight Pipeline (Selection)", priority = CoreUtils.editMenuPriority)]
         //public static void UpgradeMaterialsToLDSelection()
         //{
         //    List<MaterialUpgrader> materialUpgraders = new List<MaterialUpgrader>();

ScriptableRenderPipeline/LightweightPipeline/Editor/StandardToLightweightMaterialUpgrader.cs

 {
     public class StandardToLightweightMaterialUpgrader
     {
-        [MenuItem("Edit/Render Pipeline/Lightweight/Upgrade/Upgrade Standard Materials to Lightweight Pipeline (Project)", priority = CoreUtils.editMenuPriority)]
+        [MenuItem("Edit/Render Pipeline/Upgrade/Lightweight/Upgrade Standard Materials to Lightweight Pipeline (Project)", priority = CoreUtils.editMenuPriority2)]
         private static void UpgradeMaterialsToLDProject()
         {
             List<MaterialUpgrader> upgraders = new List<MaterialUpgrader>();
         }
 
-        [MenuItem("Edit/Render Pipeline/Lightweight/Upgrade/Upgrade Standard Materials to Lightweight Pipeline (Selection)", priority = CoreUtils.editMenuPriority)]
+        [MenuItem("Edit/Render Pipeline/Upgrade/Lightweight/Upgrade Standard Materials to Lightweight Pipeline (Selection)", priority = CoreUtils.editMenuPriority2)]
         private static void UpgradeMaterialsToLDSelection()
         {
             List<MaterialUpgrader> upgraders = new List<MaterialUpgrader>();

ScriptableRenderPipeline/LightweightPipeline/LightweightPipelineAsset.cs

         [SerializeField] private Shader m_DefaultShader;
 
 #if UNITY_EDITOR
-        [UnityEditor.MenuItem("Assets/Create/Render Pipeline/Lightweight/Render Pipeline", priority = CoreUtils.assetCreateMenuPriority)]
+        [UnityEditor.MenuItem("Assets/Create/Render Pipeline/Lightweight/Render Pipeline", priority = CoreUtils.assetCreateMenuPriority1)]
         static void CreateLightweightPipeline()
         {
             var instance = ScriptableObject.CreateInstance<LightweightPipelineAsset>();

TestbedPipelines/BasicRenderPipeline/BasicRenderPipeline.cs

     public bool UseIntermediateRenderTargetBlit;
 
 #if UNITY_EDITOR
-    [UnityEditor.MenuItem("Assets/Create/Render Pipeline/Basic/Render Pipeline", priority = CoreUtils.assetCreateMenuPriority)]
+    [UnityEditor.MenuItem("Assets/Create/Render Pipeline/Basic/Render Pipeline", priority = CoreUtils.assetCreateMenuPriority1)]
     static void CreateBasicRenderPipeline()
     {
         var instance = ScriptableObject.CreateInstance<BasicRenderPipeline>();

TestbedPipelines/Fptl/FptlLighting.cs

     public class FptlLighting : RenderPipelineAsset
     {
 #if UNITY_EDITOR
-        [UnityEditor.MenuItem("Assets/Create/Render Pipeline/FPTL/Render Pipeline", priority = CoreUtils.assetCreateMenuPriority)]
+        [UnityEditor.MenuItem("Assets/Create/Render Pipeline/FPTL/Render Pipeline", priority = CoreUtils.assetCreateMenuPriority1)]
         static void CreateRenderLoopFPTL()
         {
             var instance = ScriptableObject.CreateInstance<FptlLighting>();

TestbedPipelines/OnTileDeferredPipeline/OnTileDeferredRenderPipeline.cs

 	public class OnTileDeferredRenderPipeline : RenderPipelineAsset {
 
 	#if UNITY_EDITOR
-		[UnityEditor.MenuItem("Assets/Create/Render Pipeline/On Tile Deferred/Render Pipeline", priority = CoreUtils.assetCreateMenuPriority)]
+		[UnityEditor.MenuItem("Assets/Create/Render Pipeline/On Tile Deferred/Render Pipeline", priority = CoreUtils.assetCreateMenuPriority1)]
 		static void CreateDeferredRenderPipeline()
 		{
 			var instance = ScriptableObject.CreateInstance<OnTileDeferredRenderPipeline> ();
-		[UnityEditor.MenuItem("Edit/Render Pipeline/On Tile Deferred/Upgrade/Upgrade Standard Shader Materials", priority = CoreUtils.editMenuPriority)]
+		[UnityEditor.MenuItem("Edit/Render Pipeline/Upgrade/On Tile Deferred/Upgrade Standard Shader Materials", priority = CoreUtils.editMenuPriority2)]
 		static void SetupDeferredRenderPipelineMaterials()
 		{
 			Renderer[] _renderers = Component.FindObjectsOfType<Renderer> ();