Merge pull request #416 from EvgeniiG/Unity-2017.3

Add helper code to solve issues with reflection probes

ScriptableRenderPipeline/Core/TextureCache.cs

 
 
             // wrap up
-            Debug.Assert(bFoundAvailOrExistingSlice);   // if this fails either increase the size of the texture cache or reduce number of unique cached textures in use.
+            Debug.Assert(bFoundAvailOrExistingSlice, "The texture cache doesn't have enough space to store all textures. Please either increase the size of the texture cache, or use fewer unique textures.");
             if (bFoundAvailOrExistingSlice)
             {
                 m_SliceArray[sliceIndex].countLRU = 0;      // mark slice as in use this frame

ScriptableRenderPipeline/HDRenderPipeline/Lighting/TilePass/TilePass.cs

             static Texture2DArray m_DefaultTexture2DArray;
 
             TextureCacheCubemap m_CubeReflTexArray;
+            int m_CubeReflTexArraySize = 128;
+            int m_CookieTexArraySize = 16;
+            int m_CubeCookieTexArraySize = 16;
 
             public class LightList
             {
                 s_shadowDatas = new ComputeBuffer(k_MaxCascadeCount + k_MaxShadowOnScreen, System.Runtime.InteropServices.Marshal.SizeOf(typeof(ShadowData)));
 
                 m_CookieTexArray = new TextureCache2D();
-                m_CookieTexArray.AllocTextureArray(8, textureSettings.spotCookieSize, textureSettings.spotCookieSize, TextureFormat.RGBA32, true);
+                m_CookieTexArray.AllocTextureArray(m_CookieTexArraySize, textureSettings.spotCookieSize, textureSettings.spotCookieSize, TextureFormat.RGBA32, true);
-                m_CubeCookieTexArray.AllocTextureArray(4, textureSettings.pointCookieSize, TextureFormat.RGBA32, true);
+                m_CubeCookieTexArray.AllocTextureArray(m_CubeCookieTexArraySize, textureSettings.pointCookieSize, TextureFormat.RGBA32, true);
-                m_CubeReflTexArray.AllocTextureArray(32, textureSettings.reflectionCubemapSize, TextureCache.GetPreferredHdrCompressedTextureFormat, true);
+                m_CubeReflTexArray.AllocTextureArray(m_CubeReflTexArraySize, textureSettings.reflectionCubemapSize, TextureCache.GetPreferredHdrCompressedTextureFormat, true);
 
                 s_GenAABBKernel = buildScreenAABBShader.FindKernel("ScreenBoundsAABB");
 
                         // probe.texture can be null when we are adding a reflection probe in the editor
                         if (probe.texture == null || envLightCount >= k_MaxEnvLightsOnScreen)
                             continue;
+
+                        // Work around the culling issues. TODO: fix culling in C++.
+                        if (probe.probe == null || !probe.probe.isActiveAndEnabled)
+                            continue;
+
+                        // Work around the data issues.
+                        if (probe.localToWorld.determinant == 0)
+                        {
+                            Debug.LogError("Reflection probe " + probe.probe.name + " has an invalid local frame and needs to be fixed.");
+                            continue;
+                        }
 
                         // TODO: Support LightVolumeType.Sphere, currently in UI there is no way to specify a sphere influence volume
                         LightVolumeType lightVolumeType = probe.boxProjection != 0 ? LightVolumeType.Box : LightVolumeType.Box;