Merge pull request #965 from Unity-Technologies/Expose-bias-control-parameter

Expose bias control parameter

ScriptableRenderPipeline/HDRenderPipeline/HDRP/Editor/Lighting/HDLightEditor.Styles.cs

             public readonly GUIContent contactShadowFadeDistance = new GUIContent("Fade Distance", "Distance in world units over which the contact shadows are faded out (see Max Distance).");
             public readonly GUIContent contactShadowSampleCount = new GUIContent("Sample Count", "Number of samples when ray casting.");
 
+            // Bias control
+            public readonly GUIContent viewBiasMin = new GUIContent("view Bias");
+            public readonly GUIContent viewBiasMax = new GUIContent("view Bias Max");
+            public readonly GUIContent viewBiasScale = new GUIContent("view Bias Scale");
+            public readonly GUIContent normalBiasMin = new GUIContent("normal Bias");
+            public readonly GUIContent normalBiasMax = new GUIContent("normal Bias Max");
+            public readonly GUIContent normalBiasScale = new GUIContent("normal Bias Scale");
+            public readonly GUIContent sampleBiasScale = new GUIContent("sample Bias Scale");
+            public readonly GUIContent edgeLeakFixup = new GUIContent("edge Leak Fixup");
+            public readonly GUIContent edgeToleranceNormal = new GUIContent("edge Tolerance Normal");
+            public readonly GUIContent edgeTolerance = new GUIContent("edge Tolerance");
+
             public Styles()
             {
                 shapeNames = Enum.GetNames(typeof(LightShape))

ScriptableRenderPipeline/HDRenderPipeline/HDRP/Editor/Lighting/HDLightEditor.cs

             public SerializedProperty contactShadowMaxDistance;
             public SerializedProperty contactShadowFadeDistance;
             public SerializedProperty contactShadowSampleCount;
+
+            // Bias control
+            public SerializedProperty viewBiasMin;
+            public SerializedProperty viewBiasMax;
+            public SerializedProperty viewBiasScale;
+            public SerializedProperty normalBiasMin;
+            public SerializedProperty normalBiasMax;
+            public SerializedProperty normalBiasScale;
+            public SerializedProperty sampleBiasScale;
+            public SerializedProperty edgeLeakFixup;
+            public SerializedProperty edgeToleranceNormal;
+            public SerializedProperty edgeTolerance;
         }
 
         SerializedObject m_SerializedAdditionalLightData;
                 contactShadowMaxDistance = o.Find(x => x.contactShadowMaxDistance),
                 contactShadowFadeDistance = o.Find(x => x.contactShadowFadeDistance),
                 contactShadowSampleCount = o.Find(x => x.contactShadowSampleCount),
+
+                viewBiasMin = o.Find(x => x.viewBiasMin),
+                viewBiasMax = o.Find(x => x.viewBiasMax),
+                viewBiasScale = o.Find(x => x.viewBiasScale),
+                normalBiasMin = o.Find(x => x.normalBiasMin),
+                normalBiasMax = o.Find(x => x.normalBiasMax),
+                normalBiasScale = o.Find(x => x.normalBiasScale),
+                sampleBiasScale = o.Find(x => x.sampleBiasScale),
+                edgeLeakFixup = o.Find(x => x.edgeLeakFixup),
+                edgeToleranceNormal = o.Find(x => x.edgeToleranceNormal),
+                edgeTolerance = o.Find(x => x.edgeTolerance)
             };
         }
 
             }
 
             EditorGUILayout.PropertyField(m_AdditionalShadowData.resolution, s_Styles.shadowResolution);
-            EditorGUILayout.Slider(settings.shadowsBias, 0.001f, 1f, s_Styles.shadowBias);
-            EditorGUILayout.Slider(settings.shadowsNormalBias, 0.001f, 1f, s_Styles.shadowNormalBias);
+            //EditorGUILayout.Slider(settings.shadowsBias, 0.001f, 1f, s_Styles.shadowBias);
+            //EditorGUILayout.Slider(settings.shadowsNormalBias, 0.001f, 1f, s_Styles.shadowNormalBias);
+            EditorGUILayout.Slider(m_AdditionalShadowData.viewBiasScale, 0.0f, 15.0f, s_Styles.viewBiasScale);
             EditorGUILayout.Slider(settings.shadowsNearPlane, 0.01f, 10f, s_Styles.shadowNearPlane);
 
             if (settings.lightType.enumValueIndex == (int)LightType.Directional)
                     EditorGUILayout.PropertyField(m_AdditionalShadowData.fadeDistance, s_Styles.shadowFadeDistance);
 
                 EditorGUILayout.PropertyField(m_AdditionalShadowData.dimmer, s_Styles.shadowDimmer);
+
+                EditorGUILayout.Slider(m_AdditionalShadowData.viewBiasMin, 0.0f, 5.0f, s_Styles.viewBiasMin);
+                //EditorGUILayout.PropertyField(m_AdditionalShadowData.viewBiasMax, s_Styles.viewBiasMax);
+                EditorGUI.BeginChangeCheck();
+                EditorGUILayout.Slider(m_AdditionalShadowData.normalBiasMin, 0.0f, 5.0f, s_Styles.normalBiasMin);
+                if (EditorGUI.EndChangeCheck())
+                {
+                    // Link min to max and don't expose normalBiasScale (useless when min == max)                    
+                    m_AdditionalShadowData.normalBiasMax = m_AdditionalShadowData.normalBiasMin;
+                }
+                //EditorGUILayout.PropertyField(m_AdditionalShadowData.normalBiasMax, s_Styles.normalBiasMax);
+                //EditorGUILayout.PropertyField(m_AdditionalShadowData.normalBiasScale, s_Styles.normalBiasScale);
+                //EditorGUILayout.PropertyField(m_AdditionalShadowData.sampleBiasScale, s_Styles.sampleBiasScale);
+                EditorGUILayout.PropertyField(m_AdditionalShadowData.edgeLeakFixup, s_Styles.edgeLeakFixup);
+                //EditorGUILayout.PropertyField(m_AdditionalShadowData.edgeToleranceNormal, s_Styles.edgeToleranceNormal);
+                //EditorGUILayout.PropertyField(m_AdditionalShadowData.edgeTolerance, s_Styles.edgeTolerance);
                 EditorGUI.indentLevel--;
             }
         }