Merge pull request #98 from Unity-Technologies/node-bugfixes

Maths nodes bugfixes

MaterialGraphProject/Assets/UnityShaderEditor/Editor/Data/Interfaces/NeededCoordinateSpace.cs

 
         public static string ToVariableName(this CoordinateSpace space, InterpolatorType type)
         {
-            var index = (int)space * s_SpaceCount + (int)type;
+            var index = (int)space + (int)type * s_SpaceCount;
             if (string.IsNullOrEmpty(s_VariableNames[index]))
                 s_VariableNames[index] = string.Format("{0}Space{1}", space, type);
             return s_VariableNames[index];

MaterialGraphProject/Assets/UnityShaderEditor/Editor/Data/Nodes/Math/Derivative/DDXNode.cs

         }
 
         static string Unity_DDX_Default(
-            [Slot(0, Binding.None)] Vector1 In,
-            [Slot(1, Binding.None)] out Vector1 Out)
+            [Slot(0, Binding.None)] DynamicDimensionVector In,
+            [Slot(1, Binding.None)] out DynamicDimensionVector Out)
         {
             return
                 @"
         }
 
         static string Unity_DDX_Coarse(
-            [Slot(0, Binding.None)] Vector1 In,
-            [Slot(1, Binding.None)] out Vector1 Out)
+            [Slot(0, Binding.None)] DynamicDimensionVector In,
+            [Slot(1, Binding.None)] out DynamicDimensionVector Out)
         {
             return
                 @"
         }
 
         static string Unity_DDX_Fine(
-            [Slot(0, Binding.None)] Vector1 In,
-            [Slot(1, Binding.None)] out Vector1 Out)
+            [Slot(0, Binding.None)] DynamicDimensionVector In,
+            [Slot(1, Binding.None)] out DynamicDimensionVector Out)
         {
             return
                 @"

MaterialGraphProject/Assets/UnityShaderEditor/Editor/Data/Nodes/Math/Derivative/DDXYNode.cs

         }
 
         static string Unity_DDXY_Default(
-            [Slot(0, Binding.None)] Vector1 In,
-            [Slot(1, Binding.None)] out Vector1 Out)
+            [Slot(0, Binding.None)] DynamicDimensionVector In,
+            [Slot(1, Binding.None)] out DynamicDimensionVector Out)
         {
             return
                 @"
         }
 
         static string Unity_DDXY_Coarse(
-            [Slot(0, Binding.None)] Vector1 In,
-            [Slot(1, Binding.None)] out Vector1 Out)
+            [Slot(0, Binding.None)] DynamicDimensionVector In,
+            [Slot(1, Binding.None)] out DynamicDimensionVector Out)
         {
             return
                 @"
         }
 
         static string Unity_DDXY_Fine(
-            [Slot(0, Binding.None)] Vector1 In,
-            [Slot(1, Binding.None)] out Vector1 Out)
+            [Slot(0, Binding.None)] DynamicDimensionVector In,
+            [Slot(1, Binding.None)] out DynamicDimensionVector Out)
         {
             return
                 @"

MaterialGraphProject/Assets/UnityShaderEditor/Editor/Data/Nodes/Math/Derivative/DDYNode.cs

         }
 
         static string Unity_DDY_Default(
-            [Slot(0, Binding.None)] Vector1 In,
-            [Slot(1, Binding.None)] out Vector1 Out)
+            [Slot(0, Binding.None)] DynamicDimensionVector In,
+            [Slot(1, Binding.None)] out DynamicDimensionVector Out)
         {
             return
                 @"
         }
 
         static string Unity_DDY_Coarse(
-            [Slot(0, Binding.None)] Vector1 In,
-            [Slot(1, Binding.None)] out Vector1 Out)
+            [Slot(0, Binding.None)] DynamicDimensionVector In,
+            [Slot(1, Binding.None)] out DynamicDimensionVector Out)
         {
             return
                 @"
         }
 
         static string Unity_DDY_Fine(
-            [Slot(0, Binding.None)] Vector1 In,
-            [Slot(1, Binding.None)] out Vector1 Out)
+            [Slot(0, Binding.None)] DynamicDimensionVector In,
+            [Slot(1, Binding.None)] out DynamicDimensionVector Out)
         {
             return
                 @"

MaterialGraphProject/Assets/UnityShaderEditor/Editor/Data/Nodes/Math/Vector/CrossProductNode.cs

 using System.Reflection;
+using UnityEngine;
 
 namespace UnityEditor.ShaderGraph
 {
         }
 
         static string Unity_CrossProduct(
-            [Slot(0, Binding.None)] DynamicDimensionVector A,
-            [Slot(1, Binding.None)] DynamicDimensionVector B,
-            [Slot(2, Binding.None)] out DynamicDimensionVector Out)
+            [Slot(0, Binding.None)] Vector3 A,
+            [Slot(1, Binding.None)] Vector3 B,
+            [Slot(2, Binding.None)] out Vector3 Out)
+            Out = Vector3.zero;
             return
                 @"
 {

MaterialGraphProject/Assets/UnityShaderEditor/Editor/Data/Nodes/Math/Vector/DistanceNode.cs

         static string Unity_Distance(
             [Slot(0, Binding.None)] DynamicDimensionVector A,
             [Slot(1, Binding.None)] DynamicDimensionVector B,
-            [Slot(2, Binding.None)] out DynamicDimensionVector Out)
+            [Slot(2, Binding.None)] out Vector1 Out)
         {
             return
                 @"

MaterialGraphProject/Assets/UnityShaderEditor/Editor/Data/Nodes/Math/Vector/ReflectionNode.cs

         }
 
         static string Unity_Reflection(
-            [Slot(0, Binding.None)] Vector3 In,
-            [Slot(1, Binding.None)] Vector3 Normal,
-            [Slot(2, Binding.None)] out Vector3 Out)
+            [Slot(0, Binding.None)] DynamicDimensionVector In,
+            [Slot(1, Binding.None)] DynamicDimensionVector Normal,
+            [Slot(2, Binding.None)] out DynamicDimensionVector Out)
-            Out = Vector3.one;
 
             return @"
 {